Open
Conversation
Contributor
|
I think there is some merit in providing separate toggles for each provider for fine grained control. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
realDayaa
reviewed
Apr 2, 2026
|
|
||
| function toAbsoluteLink(link) { | ||
| if (!link) return null; | ||
| return link.startsWith('http') ? link : `https://www.kleinanzeigen.de${link}`; |
Contributor
There was a problem hiding this comment.
Use Javascript URL object instead to construct.
|
|
||
| const locality = cleanText(address.addressLocality); | ||
| const region = cleanText(address.addressRegion); | ||
| const postalCode = cleanText(address.postalCode); |
Contributor
There was a problem hiding this comment.
Since the description is stored in #viewad-description-text it can probably be treated the same as the address.
lib/FredyPipelineExecutioner.js
Outdated
| if (!userId || !getUserSettings(userId)?.provider_details) { | ||
| return newListings; | ||
| } | ||
| return Promise.all(newListings.map((listing) => this._providerConfig.fetchDetails(listing, this._browser))); |
Contributor
There was a problem hiding this comment.
This runs all requests in parallel, right? Isn't it better to run them sequentially to avoid rate limiting?
Owner
Author
There was a problem hiding this comment.
good arguemnt. will do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a generic method for provider to fetch details.
This pr is based on the initial work of @realDayaa.